-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lebovits/refactor etl pipeline #1014
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…yet finished--need to handle mismatched number of observations
Removing
Relevant for #997 |
This was referenced Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does several major things:
main.py
to create a new ETL pipeline based around the full OPA properties dataset as opposed toscript.py
, which is only based around the vacant properties datasets.data_utils
and other files relevant to the pipeline, storying them in thenew_etl
subdirectory to avoid conflicts with the main pipeline.Currently, it runs without changes to the Docker setup. Run
docker compose -d postgres
, thendocker compose run vacant-lots-proj bash
, and thenpipenv run python -m main
. This is because the data are not written to a postgres database. We're waiting on #997 to do this, somain.py
just writes totest_output.parquet
in thetmp/
directory for now.Some points of note:
n_contiguous
is being calculated. It worked fine with the vacant properties data alone; I am not 100% sure I have it working properly here.park_priority
andtree_canopy_gap
datasets, which are both national-level data (I think from the same Parkserve dataset). It would be nice to fix these, but it's not a priority right now.