Csv reader #21
Open
Csv reader #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
February 23, 2016 19:21
|
Hey Ben, I think the issue might be that your JavaScript isn't standardized. I had the same problem as well. Here's a link for how to format JavaScript: |
|
Hi thanks for the link. I think it's weird that travis enforces no semicolons at the end of the line. I used to work with lint, and it enforced the exact opposite rule! |
|
Haha yeah I know! I'm so used to using semicolons. |
|
Travis is running both standardjs and travis. Here are the details for your build: https://travis-ci.org/CfABrigadePhiladelphia/jawn/jobs/113008574 It's failing with some style complaints from standardjs. |
|
Oops. Didn't see your comments! I bet we can change the settings for standardjs if we have our own style preferences, or we could just turn it off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I took at stab at the csv to json reader. Not sure if this is what we are trying to do.
Also, I am having trouble integrating tape with travis-ci. The build fails and so does npm test. However if I run the tests locally they all pass. Any ideas?