Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support lazy computation of hasFixedSize #882

Closed
wants to merge 2 commits into from
Closed

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Nov 3, 2023

No description provided.

@fmeum fmeum requested a review from bertschneider November 3, 2023 12:58
Copy link

ci-fuzz-check bot commented Nov 3, 2023

findings-found-icon 2 open findings detected  View Findings
The final number may be higher than displayed as the scan progresses in the background. For more information, check the Code Intelligence Documentation

fmeum added 2 commits November 6, 2023 17:53
This allows mutators for potentially recursive structures to still
derive their value of `hasFixedSize` from that of child mutators, which
is necessary to support mutators with arbitrary child mutators.

Mutators can either override `hasFixedSize` to return a fixed value or
`computeHasFixedSize` to compute and cache the value the first time
`hasFixedSize` is invoked.

This fixes a bug that previously resulted in `Any` messages always being
treated as variable size even with an `@AnySource` pointing to
exclusively fixed-size messages.
@fmeum fmeum force-pushed the FUZZ-655-has-fixed-size branch from a6b0898 to d5cfe5b Compare November 6, 2023 16:53
@fmeum fmeum closed this Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant