Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

G #2

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

G #2

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,5 @@ Clear Function: Quickly reset calculations.
Technologies Used
HTML for structure
CSS for styling and responsive design
JavaScript for handling calculations and interactions
JavaScript for handling calculations and interactions
i add color and background to this calculator
19 changes: 14 additions & 5 deletions style.css
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
.body_calc{
margin: auto;
background-color: gray;
background-color: rgb(111, 132, 104);
color: white;
padding:1rem;
width: 40%;
border-radius: 1.6rem;
align-items: center;
}
.button{
color:aliceblue;
color:rgb(86, 152, 210);
background-color: red;
border:2px;
display: inline-flex;
Expand All @@ -17,11 +17,11 @@
margin-right: 2px;
border-radius: 20px;
font-size:15px;
background: linear-gradient(135deg, #d9d9d9, #7f7f7f);
background: linear-gradient(135deg, #d9d9d9, #0a0101);
color: black;
}
.button:hover{
background-color: #0056b3;
background-color: #457db8;
}
.display {
width: 94%;
Expand Down Expand Up @@ -64,4 +64,13 @@
display: flex;
justify-content: space-around;
align-items: center;
}
}

body {
background-image: url(https://img.freepik.com/premium-vector/pi-day-seamless-pattern-with-mathematical-constants-baked-pie-template-hand-drawn-illustration_2175-12164.jpg?semt=ais_hybrid); /* Replace with your image path */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 suggestion (security): Consider hosting the background image locally instead of loading from an external domain

External image dependencies can cause security vulnerabilities, performance issues, and reliability problems. The image should be downloaded and hosted alongside the application assets.

    background-image: url('../images/pi-pattern.jpg');

background-size: cover; /* Cover the entire body */
background-position: center; /* Center the image */
background-repeat: no-repeat; /* Prevent the image from repeating */
height: 100vh; /* Ensure the body takes the full height of the viewport */
margin: 0; /* Remove default margin */
}