This repository was archived by the owner on Oct 2, 2024. It is now read-only.
html/css-week3-Ebrahim Beiati-Asl #245
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SallyMcGrath
reviewed
Apr 6, 2023
There was a problem hiding this comment.
Thanks so much for your hard work here, @ebrahimbeiati . This looks really good. Well done on getting that perfect Lighthouse score.
I've left a few tiny notes for you to think about. Take a look and have a think. And well done! ⭐
| </select> | ||
|
|
||
| <label for="deliveryDate">Delivery date:</label> | ||
| <input type="date" id="deliveryDate" name="deliveryDate" min="<?php echo date('Y-m-d'); ?>" max="<?php echo date('Y-m-d', strtotime('+4 weeks')); ?>" required> |
There was a problem hiding this comment.
This task asks you to use HTML and CSS only. What is this php doing here? When you tested your form, what happened?
| <footer> | ||
| <!-- change to your name--> | ||
| <h2>By HOMEWORK SOLUTION</h2> | ||
| <h2>By Ebrahim Beiati-Asl</h2> |
There was a problem hiding this comment.
⭐ Good attention to detail.
| cursor: pointer; | ||
| } | ||
|
|
||
| button[type="submit"]:hover { |
There was a problem hiding this comment.
What would happen if the user was not using a mouse? Is there another focus state that you could add to this rule to make it work in other contexts?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.