WM | 25-ITP-May | Abdullah Saleh | Sprint 3 | Quote Generator #688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: The first 6 commits were pushed accidentally and are not part of the intended changes for this pull request. Unfortunately, I couldn't remove them from the PR history. |
cjyuan
reviewed
Jul 30, 2025
Sprint-3/quote-generator/quotes.js
Outdated
| const author = document.querySelector("#author"); | ||
|
|
||
| // Attach a click event listener to the "New Quote" button | ||
| const newClick = document.querySelector(".btn").addEventListener("click", () => { |
There was a problem hiding this comment.
-
What's the use of variable
newClick? -
CSS
classcan be shared by multiple elements. It is better assignidattribute to uniquely identify an element in HTML.
There was a problem hiding this comment.
Thanks for the suggestion! I've updated the button to use an id instead of a class for more precise selection and to avoid potential conflicts. Also, I removed the unnecessary newClick button
cjyuan
added
Reviewed
3bdullah-saleh
added
Needs Review
|
Changes look good. Well done! |
cjyuan
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.