WESTMIDLANDS| ITP-MAY2025| Roja Alagurajan| Alarm Clock. #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjyuan
reviewed
Jul 30, 2025
Sprint-3/alarmclock/alarmclock.js
Outdated
Comment on lines
23
to
25
| updateTitle(); | ||
| } else { | ||
| updateTitle(); |
There was a problem hiding this comment.
It seems the app is going to call updateTitle() regardless of the condition. Perhaps you can factor out the common statement from of if-else block.
There was a problem hiding this comment.
Hi @cjyuan ,
Thank you for your suggestion regarding refactoring the updateTitle() calls. I have updated my code by removing the else block and calling updateTitle() once after the conditional check inside the timer interval.
cjyuan
added
Reviewed
alagurajan-roja
added
Needs Review
|
Changes look good. Well done! |
cjyuan
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.