GLASGOW | May-2025 | Taras Mykytiuk | Module-Data-Groups | Sprint_3 | Todo_List #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LonMcGregor
reviewed
Jul 25, 2025
There was a problem hiding this comment.
Good work on the todo list task so far - there seems to be an issue with delete. I have not reviewed the reading list - did you mean to commit that here, or should that have been on a separate branch / pull request? If so can you remove those files from this PR please
Sprint-3/todo-list/script.js
Outdated
| // Advanced challenge: Write a fucntion that checks the todos in the todo list and deletes the completed ones (we can check which ones are completed by seeing if they have the line-through styling applied or not). | ||
| function deleteAllCompletedTodos() { | ||
| // Write your code here... | ||
| } | ||
| const activeListElements = listDom.children; |
There was a problem hiding this comment.
If I have multiple completed list items, when I use the delete all function, it only removes about half of all the elements.
There was a problem hiding this comment.
I have fixed this by changing loop direction.
LonMcGregor
added
Reviewed
TarasMykytiuk
force-pushed
the
sprint_3_todo_list_app
branch
from
674a778 to
4eb5fdf
Compare
TarasMykytiuk
added
Needs Review
|
Great! That works. This sprint task is complete now. Well done. |
LonMcGregor
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Page has ability to add items to list, mark them as completed and delete.
Questions
Ask any questions you have for your reviewer.