ZA-ITP-May-2025 | Christian Mayamba | Module-Data-Groups | Week 2 #699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
day-lee
reviewed
Jul 30, 2025
day-lee
reviewed
Jul 30, 2025
day-lee
reviewed
Jul 30, 2025
day-lee
added
Reviewed
c-mayamba
added
Needs Review
day-lee
reviewed
Jul 30, 2025
Comment on lines
+8
to
+15
| for (const item of array) { | ||
| if (result[item]) { | ||
| result[item] = result[item] + 1; | ||
| } else { | ||
| result[item] = 1; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Well done! As a challenge, can you refactor the code with an array method and ternary operator so the code can be more simple and concise?
day-lee
reviewed
Jul 30, 2025
There was a problem hiding this comment.
Good job!
In the real world, URLs are usually encoded with percent encoding to represent special characters. In URL, & can be used as a separator (key=value&key=value...) or special character within a key or value. if we were to use & as a special character, we need to encode it.
Can you refactor the code so that parseQueryString("a%25b=c%26d") results in { "a%b": "c&d" }?
FYI, %25 is same as %, %26 is same as &
|
Hi @c-mayamba. Thank you for refactoring the code accordingly. I left two more reviews. |
day-lee
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.