Skip to content

ZA Cape Town | ITP-May-2025 | Dawud Vermeulen | Sprint 3 | Module-Data-Groups #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

ZA Cape Town | ITP-May-2025 | Dawud Vermeulen | Sprint 3 | Module-Data-Groups #701

wants to merge 5 commits into from

Conversation

Dave-Vermeulen
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

I did the alarmclock a while ago so just ran the tests to make sure its fine. worked on slideshow and just followed the TDD approach, didn't even run it on a live server, it passes everything.

Questions

Please review my code and let me know if any changes are required.

@Dave-Vermeulen Dave-Vermeulen added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 25, 2025
@thebolarin thebolarin added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 25, 2025
@thebolarin
Copy link

@Dave-Vermeulen Please notify me when the todo has been completed

@cjyuan
Copy link
Contributor

cjyuan commented Jul 30, 2025

@Dave-Vermeulen @thebolarin
Each of the exercises in the "Sprint-3" folder (e.g., alarm-clock, quote-generator) is expected to be worked on in a separate branch. The trainee is expected to submitted separate PR for the "alarm-clock" and the "quote-generator" exercises.

Dave, can you submit separate PRs for these exercises?

@Dave-Vermeulen
Copy link
Author

@thebolarin so the 'ToDo' is not required for this module success right?! if this is not true then I'm happy to complete else I'm going to follow @cjyuan instruction and get these in separate branches.

@thebolarin
Copy link

You can follow @cjyuan 's instructions

@cjyuan
Copy link
Contributor

cjyuan commented Jul 31, 2025

@Dave-Vermeulen The "Todo" is not required but you should still create separate branches for alarm-clock and quote-generator exercises. @thebolarin can continue reviewing your work on the new PRs or mark them as "complete" if no change is needed.

@Dave-Vermeulen
Copy link
Author

These have been split into respective PR and branches as recommended and so closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dave-Vermeulen @thebolarin @cjyuan