ZA | 25-ITP-May | Malusi Skunyana | Sprint 3 | Quote Generator #707
+146
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /* Button styling */ | ||
| button { | ||
| background-color: var(--accent-color); | ||
| color: white; |
There was a problem hiding this comment.
It is better to be consistent and use hex here as you did earlier.
There was a problem hiding this comment.
Thanks Waldo, I appreciate the feedback.
| font-size: 1rem; | ||
| border-radius: 3px; | ||
| cursor: pointer; | ||
| margin-top: 30px; |
There was a problem hiding this comment.
Usually it is better to use relative units like vw and vh for example. This makes building for mobile easier.
|
well done |
Waldo-Strydom
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Updated the title element in
index.htmlto "Quote generator app", wrote a program to call the pickFromArray function, added auto-play functionality, and wrote CSS for the page.Questions
Ask any questions you have for your reviewer.