ZA | ITP-May-2025 | Rashaad Ebrahim | Module Data Groups | Alarm Clock #711
+6,228
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rashaad-Ebrahim
added
the
Needs Review
6 tasks
| @@ -1,4 +1,74 @@ | |||
| function setAlarm() {} | |||
| const timeRemainingDisplay = document.querySelector("#timeRemaining"); | |||
| const alarmSetInput = document.querySelector("#alarmSet"); | |||
There was a problem hiding this comment.
querySelector does not work on all nodes within the DOM. It works here, but does not always work, just something to keep in mind.
|
Well done |
Waldo-Strydom
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Implementaion of the alarm clock project
Questions
No questions