Sheffield| May 2025| Mayowa Fadare| Sprint 3| Alarm Clock #712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayowa0-7
added
the
Needs Review
arun-john
added
Review in progress
cjyuan
reviewed
Aug 1, 2025
There was a problem hiding this comment.
- On page load, the clock shows 10 seconds. Why starts at 10 seconds?
- When the clock countdowns to 0, the input field is disabled. Once disabled, I could not figure out a way to enable it.
- I don't understand how the interface work.
- "Start Alarm" and "Pause Alarm" buttons are disabled at all times.
- What is the purpose of the "Flash Background" button?
- Only three of the buttons are assigned an event listener. That means four of the buttons won't respond to mouse click (even when they are enabled).
- While the clock is counting down, clicking "Stop Alarm" follow by clicking "Resume Alarm" will trigger the alarm sound even though the countdown has not yet reached zero.
Sprint-3/alarmclock/alarmclock.js
Outdated
Comment on lines
104
to
57
| if (typeof window !== "undefined") { | ||
| window.onload = setup; | ||
| window.setup = setup; | ||
| window.setAlarm = setAlarm; | ||
| window.pauseAlarm = pauseAlarm; | ||
| window.resumeAlarm = resumeAlarm; | ||
| window.playAlarm = playAlarm; | ||
| window.flashBackground = flashBackground; | ||
| window.updateTimeDisplay = updateTimeDisplay; | ||
| window.formatTime = formatTime; | ||
| } |
There was a problem hiding this comment.
What is this for? Can the code work equally well without this code?
There was a problem hiding this comment.
Thanks for the review, Start and Stop button now working as expected, every other button removed.
cjyuan
added
Reviewed
mayowa0-7
added
Needs Review
mayowa0-7
force-pushed
the
Alarmclock-Sprint-3
branch
from
582910b to
3272128
Compare
cjyuan
added
Complete
mayowa0-7
force-pushed
the
Alarmclock-Sprint-3
branch
from
12ad2ca to
4a802b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.