ZA Cape Town | ITP-May-2025 | Dawud Vermeulen | Sprint 2 | Module-Data-Groups #755

Dave-Vermeulen · 2025-08-09T10:20:41Z

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist

completed the tasks within:

Debug
Implement
Interpret

Questions

Please review my PR 🙏🏽

cjyuan

You missed updating the .test.js files

cjyuan · 2025-08-09T10:39:29Z

Sprint-2/implement/contains.js

+    if(obj === null || obj === undefined){
+        return false
+    } 
+    return obj[property] !== undefined;
+}
+
+module.exports = contains; 
+// work done.


What do you expect the from the following function calls?

contains("ABC", "1"); contains(["A", "B", "C"], "1"); contains(123, "1"); contains(true, "1"); contains({ key: undefined }, "key");

Suggestion:, Look up JS "in" operator vs Object.hasOwn.

okay ended up going with Object.hasOwn

cjyuan · 2025-08-09T10:42:22Z

Sprint-2/implement/querystring.js

+    const key = parts[0];
+    const value = parts.length > 1 ? parts.slice(1).join('=') : ''; //clunky but it works to split them and stitch it together again
    queryParams[key] = value;


Please note that in real querystring, both key and value are percent-encoded or URL encoded in the URL. For example, the string "5%" will be encoded as "5%25". So to get the actual value of "5%25" (whether it is a key or value in the querystring), you should call a function to decode it.
May I suggest looking up any of these terms, and "How to decode URL encoded string in JS"?

thanks for the guidance

this took some research. thank you for making the problem real so i can relate to it better. it made me invest more in the answer

cjyuan · 2025-08-09T10:43:10Z

Sprint-2/implement/tally.js

+function tally(items) {
+    if (!Array.isArray(items)){
+        throw new TypeError('that aint no array bay bay'); //okay so this is the biggie smalls and its working
+    }
+    const counts = {};
+
+    for (const item of items){
+        counts[item] = (counts[item] || 0) +1; //simple sexy core logic
+    }
+    return counts;
+}


Does the following function call returns the value you expect?

tally(["toString", "toString"]);

Suggestion: Look up an approach to create an empty object with no inherited properties.

cjyuan · 2025-08-09T10:48:48Z

Sprint-2/interpret/invert.js

@@ -10,20 +10,30 @@ function invert(obj) {
  const invertedObj = {};

  for (const [key, value] of Object.entries(obj)) {
-    invertedObj.key = value;
+    const numKey = Number(key);


We don't have to convert the key to a number when it looks like a number.

cjyuan · 2025-08-09T10:50:03Z

Sprint-2/interpret/invert.js

+// {'1':'a'}
+// b) What is the current return value when invert is called with { a: 1, b: 2 } 
+// { '1': 'a', '2': 'b'}


These are the expected return value from the original code, not the actual return value.

okay i have edited my answer

cjyuan · 2025-08-09T10:57:52Z

Sprint-2/interpret/invert.js

 // d) Explain why the current return value is different from the target output
-
+// cause its converted to strings, the key must be a int and the value must be a string.


The question is asking, why with the original code, invert({a: 1}) does not return {'1': a} (or {1:a}).

Note: The property name (key) is always a string. Even when we express the key as a number (e.g., { 1 : 'a' }), the key will still be converted to a string '1'.

Okay i refactored the code a bit so that it makes sense. I understand the comments you made but it was difficult to circle back to this and I could not take into consideration the comment in isolation.

cjyuan

Have you also gone through my comments on Sprint-2/interpret/invert.js in the previous review?

cjyuan · 2025-08-17T21:41:41Z

Sprint-2/implement/contains.test.js

+    it('should handle non-object inputs gracefully', () => {
+        expect(contains(123, 'a')).toBe(false); // Number
+        expect(contains("hello", 'a')).toBe(false); // String
+        expect(contains([1, 2, 3], 'a')).toBe(false); // Array
+        expect(contains(true, 'a')).toBe(false)
+        expect(contains(NaN, 'a')).toBe(false)
+    });


contains([1, 2, 3], "a") could also return false because "a" is not a property (or key) of [1, 2, 3].
However, "0", "1", "2" are keys of [1, 2, 3], so it is better to specify the test as
expect(contains([1, 2, 3], "1")).toBe(false); (to ensure you are checking what you describe)

You would also need to check if the first parameter is an array in your function.

okay i added this test but then felt needed to update the function to handle it.

cjyuan · 2025-08-18T14:15:12Z

Changes look good. Well done.

sprint 2 files only

ea7155c

Dave-Vermeulen mentioned this pull request Aug 9, 2025

ZA Cape Town | ITP-May-2025 | Dawud Vermeulen | Sprint 2 | Module-Data-Groups #700

Closed

5 tasks

Dave-Vermeulen added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 9, 2025

Dave-Vermeulen mentioned this pull request Aug 5, 2025

ITP-May-2025 | Data Groups | Dawud Vermeulen Dave-Vermeulen/My-Coursework-Planner#106

Open

cjyuan added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Aug 9, 2025

cjyuan reviewed Aug 9, 2025

View reviewed changes

responding to comments on PR

13b0f1a

cjyuan reviewed Aug 17, 2025

View reviewed changes

Dave-Vermeulen added 2 commits August 18, 2025 10:31

handle the remaining reviewers comments

3da4358

updated contains function to accommodate reviewers comments

2037bb6

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 18, 2025

		// d) Explain why the current return value is different from the target output

		// cause its converted to strings, the key must be a int and the value must be a string.

Uh oh!

ZA Cape Town | ITP-May-2025 | Dawud Vermeulen | Sprint 2 | Module-Data-Groups #755

Are you sure you want to change the base?

ZA Cape Town | ITP-May-2025 | Dawud Vermeulen | Sprint 2 | Module-Data-Groups #755

Uh oh!

Conversation

Dave-Vermeulen commented Aug 9, 2025

Learners, PR Template

Changelist

Questions

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Dave-Vermeulen Aug 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Aug 18, 2025

Uh oh!

Uh oh!

Dave-Vermeulen Aug 17, 2025 •

edited

Loading

cjyuan left a comment •

edited

Loading