ZA | ITP-MAY-25 | Shannon Davids | Data Groups-Sprint-3 | AlarmClock #758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shannon-Davids
added
the
Needs Review
cjyuan
reviewed
Aug 11, 2025
Sprint-3/alarmclock/alarmclock.js
Outdated
Comment on lines
7
to
12
| const mins = Math.floor((sec % 3600) / 60); | ||
| const secs = sec % 60; | ||
| return `${String(hrs).padStart(2, "0")}:${String(mins).padStart( | ||
| 2, | ||
| "0" | ||
| )}:${String(secs).padStart(2, "0")}`; |
There was a problem hiding this comment.
Is this function needed in the app? If not, it should be removed to keep the code clean.
Sprint-3/alarmclock/alarmclock.js
Outdated
Comment on lines
31
to
37
| if (timeRemaining <= 0) { | ||
| clearInterval(countdownInterval); | ||
| updateDisplay(); | ||
| playAlarm(); | ||
| } else { | ||
| updateDisplay(); | ||
| } |
There was a problem hiding this comment.
Regardless of the condition on line 31, the app is going to call updateDisplay(). So we could factor out the function call and call the function once outside the if block.
Sprint-3/alarmclock/alarmclock.js
Outdated
Comment on lines
16
to
24
| const input = document.getElementById("alarmSet"); | ||
| const seconds = parseInt(input.value); | ||
|
|
||
| if (isNaN(seconds) || seconds <= 0) { | ||
| alert("Please enter a valid number of seconds."); | ||
| return; | ||
| } | ||
|
|
||
| clearInterval(countdownInterval); // Stop any existing countdown |
There was a problem hiding this comment.
Could also consider stopping the flashing background and the alarm sound when a new countdown is set.
cjyuan
added
Reviewed
Shannon-Davids
added
Needs Review
|
Changes look good! |
cjyuan
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.