EMIN AKTURK | BIRMINGHAM | MODULE-DATA-GROUPS - SPRINT 3

[eminakturk]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

I am aware of the indented coursework where you could see sprint 1 and sprint 2 fixes as well as sprint 3, I'm aware of the situation I will be fixing it with my next module PR.

Questions

Ask any questions you have for your reviewer.

[github-actions]

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

[github-actions]

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

[oluwatunmiisheii]

Good job here @eminakturk just some fixes here and there.

[oluwatunmiisheii]

Implementation looks good. a couple of things to fix

1. what would happen if a negative number is entered
2. If I don't type in any value and click on set alarm, the app behaves in an unexpected way. Can you fix this?

[oluwatunmiisheii]

Good implementation; it would be nice to add some CSS to make the app look nicer.

[oluwatunmiisheii]

Good job; there are some minor discrepancies in the final output vs. the expected output

Yours,

Expected

Notice the position of the author and title

[oluwatunmiisheii]

Good job here, just a few things to fix.

1. Your design does not match the expected design

Your Interfaces

(Wrong layout)

(Overflowing Image)

You can check the expected outcome here
https://github.com/eminakturk/Module-Data-Groups/blob/d780bd2eff5b0a8de65c16fdb8144299775fc6b3/Sprint-3/slideshow/example-screenshots/example-level2.png

HINT: you can give the image a defined width and height to prevent it from overflowing

https://www.w3schools.com/css/css3_images.asp

[github-actions]

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

[github-actions]

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s