Skip to content

London|May-2025|Alexandru Pocovnicu|Coursework|sprint 3 #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 19 commits into from
Closed

London|May-2025|Alexandru Pocovnicu|Coursework|sprint 3 #570

wants to merge 19 commits into from

Conversation

alexandru-pocovnicu
Copy link

@alexandru-pocovnicu alexandru-pocovnicu commented Jun 18, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Done test driven development by writing the tests first and then writing code to pass the tests

Questions

Ask any questions you have for your reviewer.

cjyuan and others added 19 commits May 6, 2025 14:44
@cjyuan
Update pull_request_template.md (CodeYourFuture#450)
4c2c13b
@alexandru-pocovnicu
d
301ccc0
@alexandru-pocovnicu
i have written the test and completed the code accordingly
aee8b64
@alexandru-pocovnicu
created the tests and added new lines of code
76d10a5
@alexandru-pocovnicu
wrote assertions and completed the code accordingly
ae4f944
@alexandru-pocovnicu
replaced the comments with jest test cases
e282ccf
@alexandru-pocovnicu
added the completed function
d81fcbb
@alexandru-pocovnicu
CREATED TEST CASES FOR THE FUNCTION
777b1e7
@alexandru-pocovnicu
replaced code with mine
9dcbdca
@alexandru-pocovnicu
written all the test cases, all passed
02ba073
@alexandru-pocovnicu
replaced with my code
7aab1ad
@alexandru-pocovnicu
wrote the second test
5eb2d42
@alexandru-pocovnicu
updated the code
743ea0a
@alexandru-pocovnicu
implemented and tested additional cases
cabdf43
@alexandru-pocovnicu
updated the code to cover the test cases
5889529
@alexandru-pocovnicu
wrote the test cases
244fe2e
@alexandru-pocovnicu
updated the code according to the test cases
3b0d529
@alexandru-pocovnicu
wrote the test cases
66ab144
@alexandru-pocovnicu
wrote the code according to test cases
93f777e
@alexandru-pocovnicu alexandru-pocovnicu added the Needs Review Participant to add when requesting review label Jun 18, 2025
@cjyuan cjyuan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review labels Jul 3, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Jul 3, 2025

Can you change this PR so that is is made against CYF's main (instead of CYF's coursework/sprint-3)?

image

@cjyuan cjyuan added 👀 Review Git Changes requested to do with Git Reviewed Volunteer to add when completing a review and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 3, 2025
@illicitonion illicitonion changed the title London|May-2025|Alexandru Pocovnicu|Coursework/sprint 3 London|May-2025|Alexandru Pocovnicu|Coursework|sprint 3 Jul 15, 2025
@illicitonion
Copy link
Member

Closing in favour of #639

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
👀 Review Git Changes requested to do with Git Reviewed Volunteer to add when completing a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandru-pocovnicu @cjyuan @illicitonion