Skip to content

WM | May-2025 | Abdullah Saleh | Sprint-3 #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
47b1a74
Implement the function and add test cases
3bdullah-saleh Jun 23, 2025
c9e25de
adding semicolon to the missing parts
3bdullah-saleh Jun 23, 2025
ff1cbee
Implement a function to check for proper fractions and add test cases
3bdullah-saleh Jun 23, 2025
bd578be
Returns the numeric value of a playing card
3bdullah-saleh Jun 23, 2025
9ff46f5
Implement the function and adding test cases
3bdullah-saleh Jun 23, 2025
a73f361
Implement the function and adding test cases
3bdullah-saleh Jun 23, 2025
06e2a86
Implement the function and adding test cases
3bdullah-saleh Jun 23, 2025
a6f7736
adding invalid card test case
3bdullah-saleh Jun 23, 2025
5753049
Update the function to handel the test cases
3bdullah-saleh Jun 24, 2025
df3199e
Implement function to handle ordinal number and added test cases.
3bdullah-saleh Jun 24, 2025
a6058f7
Implement 'repeat' function and adding test cases.
3bdullah-saleh Jun 24, 2025
b932013
create a JavaScript file
3bdullah-saleh Jun 24, 2025
de840d7
create test file for card-validator file
3bdullah-saleh Jun 24, 2025
10e1c6f
Play computer with 'find' function and answering the questions
3bdullah-saleh Jun 25, 2025
f24f108
create a function to validate the length of card number and the numbe…
3bdullah-saleh Jun 26, 2025
8305998
Implement a function to create a 16 digit number. Add test cases to …
3bdullah-saleh Jun 28, 2025
aa39192
Delete console.log function
3bdullah-saleh Jun 30, 2025
92f2da6
Fixed the return value to 'Obtuse angle' for consistency with the oth…
3bdullah-saleh Jul 16, 2025
f603a66
Handle zero denominator with error, return boolean for proper fraction.
3bdullah-saleh Jul 16, 2025
b7a90c5
Add test case for "10" card to ensure correct handling in getCardValue.
3bdullah-saleh Jul 16, 2025
134b91c
Simplify isProperFraction function and add/fix related test cases.
3bdullah-saleh Jul 16, 2025
4e1421a
Refactor repeat function formatting for clarity
3bdullah-saleh Jul 16, 2025
0245190
Simplify digit validation by returning early on first non-numeric cha…
3bdullah-saleh Jul 16, 2025
783be9e
Fix indentation of the code.
3bdullah-saleh Jul 16, 2025
87e59b4
Add positive test case to ensure valid card numbers are accepted.
3bdullah-saleh Jul 16, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions Sprint-3/1-key-implement/1-get-angle-type.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@

function getAngleType(angle) {
if (angle === 90) return "Right angle";
else if (angle === 45) return "Acute angle";
else if (angle > 90 && angle < 180) return "Obtuse angle";
else if (angle === 180) return "Straight angle";
else if (angle > 180 && angle < 360) return "Reflex angle";
// read to the end, complete line 36, then pass your test here
}

Expand Down Expand Up @@ -43,14 +47,18 @@ assertEquals(acute, "Acute angle");
// When the angle is greater than 90 degrees and less than 180 degrees,
// Then the function should return "Obtuse angle"
const obtuse = getAngleType(120);
// ====> write your test here, and then add a line to pass the test in the function above
assertEquals(obtuse, "Obtuse angle");

// Case 4: Identify Straight Angles:
// When the angle is exactly 180 degrees,
// Then the function should return "Straight angle"
// ====> write your test here, and then add a line to pass the test in the function above
const straight = getAngleType(180);
assertEquals(straight, "Straight angle");

// Case 5: Identify Reflex Angles:
// When the angle is greater than 180 degrees and less than 360 degrees,
// Then the function should return "Reflex angle"
// ====> write your test here, and then add a line to pass the test in the function above
// ====> write your test here, and then add a line to pass the test in the function above
const reflex = getAngleType(240);
assertEquals(reflex, "Reflex angle");
17 changes: 14 additions & 3 deletions Sprint-3/1-key-implement/2-is-proper-fraction.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@
// write one test at a time, and make it pass, build your solution up methodically

function isProperFraction(numerator, denominator) {
if (numerator < denominator) return true;
if (denominator === 0) throw new Error("Denominator cannot be zero");
else if (numerator < denominator) return true;
else return false;
}

// here's our helper again
Expand Down Expand Up @@ -40,14 +42,23 @@ assertEquals(improperFraction, false);
// target output: true
// Explanation: The fraction -4/7 is a proper fraction because the absolute value of the numerator (4) is less than the denominator (7). The function should return true.
const negativeFraction = isProperFraction(-4, 7);
// ====> complete with your assertion
assertEquals(negativeFraction, true);

// Equal Numerator and Denominator check:
// Input: numerator = 3, denominator = 3
// target output: false
// Explanation: The fraction 3/3 is not a proper fraction because the numerator is equal to the denominator. The function should return false.
const equalFraction = isProperFraction(3, 3);
// ====> complete with your assertion
assertEquals(equalFraction, false);

// Stretch:
// What other scenarios could you test for?

// Not a valid fraction check:
// Input: numerator = 3, denominator = 0
// target output: Undefined
// Explanation: The fraction 3/0 is not a fraction type like proper or improper because division by zero is not allowed in mathematics. The function should return undefined.
const zeroFraction = isProperFraction(3,0);
assertEquals(zeroFraction, "Denominator cannot be zero");


26 changes: 21 additions & 5 deletions Sprint-3/1-key-implement/3-get-card-value.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,12 @@
// write one test at a time, and make it pass, build your solution up methodically
// just make one change at a time -- don't rush -- programmers are deep and careful thinkers
function getCardValue(card) {
if (rank === "A") return 11;
let rank = card.slice(0, -1);
if (rank === "A" || rank === "Ace") return 11;
else if (rank >= 2 && rank <= 9) return Number(rank);
else if (rank === "10" || rank === "J" || rank === "Q" || rank === "K") return 10;
else return "Invalid card rank."

}

// You need to write assertions for your function to check it works in different cases
Expand All @@ -25,27 +30,38 @@ function assertEquals(actualOutput, targetOutput) {
// Given a card string in the format "A♠" (representing a card in blackjack - the last character will always be an emoji for a suit, and all characters before will be a number 2-10, or one letter of J, Q, K, A),
// When the function getCardValue is called with this card string as input,
// Then it should return the numerical card value
const aceofSpades = getCardValue("A♠");
assertEquals(aceofSpades, 11);
const aceOfSpades = getCardValue("A♠");
assertEquals(aceOfSpades, 11);

// Handle Number Cards (2-10):
// Given a card with a rank between "2" and "9",
// When the function is called with such a card,
// Then it should return the numeric value corresponding to the rank (e.g., "5" should return 5).
const fiveofHearts = getCardValue("5♥");
// ====> write your test here, and then add a line to pass the test in the function above
const fiveOfHearts = getCardValue("5♥");
assertEquals(fiveOfHearts, 5);

// Handle Face Cards (J, Q, K):
// Given a card with a rank of "10," "J," "Q," or "K",
// When the function is called with such a card,
// Then it should return the value 10, as these cards are worth 10 points each in blackjack.
const faceCards = getCardValue("J♣");
assertEquals(faceCards, 10);
const tenOfClubs = getCardValue("10♣");
assertEquals(tenOfClubs, 10);

// Handle Ace (A):
// Given a card with a rank of "A",
// When the function is called with an Ace,
// Then it should, by default, assume the Ace is worth 11 points, which is a common rule in blackjack.
const aceCard = getCardValue("Ace♦");
assertEquals(aceCard, 11);


// Handle Invalid Cards:
// Given a card with an invalid rank (neither a number nor a recognized face card),
// When the function is called with such a card,
// Then it should throw an error indicating "Invalid card rank."
let invalidCard = getCardValue("12♠");
assertEquals(invalidCard, "Invalid card rank.");


4 changes: 4 additions & 0 deletions Sprint-3/2-mandatory-rewrite/1-get-angle-type.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
function getAngleType(angle) {
if (angle === 90) return "Right angle";
else if (angle === 45) return "Acute angle";
else if (angle > 90 && angle < 180) return "Obtuse angle";
else if (angle === 180) return "Straight angle";
else if (angle > 180 && angle < 360) return "Reflex angle";
// replace with your completed function from key-implement

}
Expand Down
26 changes: 12 additions & 14 deletions Sprint-3/2-mandatory-rewrite/1-get-angle-type.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,19 @@ test("should identify right angle (90°)", () => {
expect(getAngleType(90)).toEqual("Right angle");
});

// REPLACE the comments with the tests
// make your test descriptions as clear and readable as possible

// Case 2: Identify Acute Angles:
// When the angle is less than 90 degrees,
// Then the function should return "Acute angle"
test("should identify acute angle (<90°)", () => {
expect(getAngleType(45)).toEqual("Acute angle");
})

// Case 3: Identify Obtuse Angles:
// When the angle is greater than 90 degrees and less than 180 degrees,
// Then the function should return "Obtuse angle"
test("should identify obtuse angle (90° < angle < 180°)", () => {
expect(getAngleType(120)).toEqual("Obtuse angle");
})

// Case 4: Identify Straight Angles:
// When the angle is exactly 180 degrees,
// Then the function should return "Straight angle"
test("should identify straight angle (angle = 180°)", () => {
expect(getAngleType(180)).toEqual("Straight angle");
})

// Case 5: Identify Reflex Angles:
// When the angle is greater than 180 degrees and less than 360 degrees,
// Then the function should return "Reflex angle"
test("should identify reflex angle (180° < angle < 360°)", () => {
expect(getAngleType(250)).toEqual("Reflex angle");
})
3 changes: 1 addition & 2 deletions Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
function isProperFraction(numerator, denominator) {
if (numerator < denominator) return true;
// add your completed function from key-implement here
return Math.abs(numerator) < Math.abs(denominator)
}

module.exports = isProperFraction;
13 changes: 12 additions & 1 deletion Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,18 @@ test("should return true for a proper fraction", () => {
});

// Case 2: Identify Improper Fractions:

test("should return false for an improper fraction", () => {
expect(isProperFraction(5, 3)).toEqual(false);
});
// Case 3: Identify Negative Fractions:
test("should return true for a proper fraction", () => {
expect(isProperFraction(-5, 10)).toEqual(true);
});
test("should return false for an improper fraction", () => {
expect(isProperFraction(-12, 6)).toEqual(false);
});

// Case 4: Identify Equal Numerator and Denominator:
test("should return false for an improper fraction", () => {
expect(isProperFraction(10, 10)).toEqual(false);
});
7 changes: 5 additions & 2 deletions Sprint-3/2-mandatory-rewrite/3-get-card-value.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
function getCardValue(card) {
// replace with your code from key-implement
return 11;
let rank = card.slice(0, -1);
if (rank === "A" || rank === "Ace") return 11;
else if (rank >= 2 && rank <= 9) return Number(rank);
else if (rank === 10 || rank === "J" || rank === "Q" || rank === "K") return 10;
else return "Invalid card rank."
}
module.exports = getCardValue;
16 changes: 16 additions & 0 deletions Sprint-3/2-mandatory-rewrite/3-get-card-value.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,22 @@ test("should return 11 for Ace of Spades", () => {
});

// Case 2: Handle Number Cards (2-10):
test("should return numeric value corresponding to the rank", () => {
const fiveofHearts = getCardValue("5♥");
expect(fiveofHearts).toEqual(5);
})
// Case 3: Handle Face Cards (J, Q, K):
test("should return 10 for J, Q, K, as these cards are worth 10 points each in blackjack.", () => {
const faceCards = getCardValue("J♠")
expect(faceCards).toEqual(10);
})
// Case 4: Handle Ace (A):
test("should return 11 as Ace as worth 11 points", () => {
const aceCard = getCardValue("Ace♦")
expect(aceCard).toEqual(11);
})
// Case 5: Handle Invalid Cards:
test("should return invalid card rank, if the number is unrecognized", () => {
const invalidCrd = getCardValue("12♠")
expect(invalidCrd).toEqual("Invalid card rank.");
})
16 changes: 14 additions & 2 deletions Sprint-3/3-mandatory-practice/implement/count.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,17 @@
function countChar(stringOfCharacters, findCharacter) {
return 5
let charNum = stringOfCharacters.split(findCharacter).length -1;
return charNum

}

module.exports = countChar;

module.exports = countChar;


/* pseudocode:
// we need to look for a specific character inside a string




*/
6 changes: 6 additions & 0 deletions Sprint-3/3-mandatory-practice/implement/count.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,9 @@ test("should count multiple occurrences of a character", () => {
// And a character char that does not exist within the case-sensitive str,
// When the function is called with these inputs,
// Then it should return 0, indicating that no occurrences of the char were found in the case-sensitive str.
test("should return 0 when the character does not occur in the string", () => {
const str = "bbbbbb";
const char = "a";
const count = countChar(str, char);
expect(count).toEqual(0);
});
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
function getOrdinalNumber(num) {
return "1st";
let oneDigit = num % 10;
let twoDigit = num % 100;
if (twoDigit >= 11 && twoDigit <= 13 ) return `${num}th`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good identification of an edge-case here - most people doing this exercise notice 12 but forget about 112!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That feedback means a lot

else if (oneDigit == 1) return `${num}st`;
else if (oneDigit == 2) return `${num}nd`;
else if (oneDigit == 3) return `${num}rd`;
else return `${num}th`;
}

module.exports = getOrdinalNumber;
55 changes: 51 additions & 4 deletions Sprint-3/3-mandatory-practice/implement/get-ordinal-number.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,55 @@ const getOrdinalNumber = require("./get-ordinal-number");

// Case 1: Identify the ordinal number for 1
// When the number is 1,
// Then the function should return "1st"
// Then the function should return "num+st"
test("works for any number ending in 1", () => {
expect(getOrdinalNumber(1)).toEqual("1st");
expect(getOrdinalNumber(41)).toEqual("41st");
expect(getOrdinalNumber(51)).toEqual("51st");
expect(getOrdinalNumber(91)).toEqual("91st");
});

test("should return '1st' for 1", () => {
expect(getOrdinalNumber(1)).toEqual("1st");
});
// Case 2: Identify the ordinal number for 2
// When the number is 2,
// Then the function should return "num+nd"
test("works for any number ending in 2", () => {
expect(getOrdinalNumber(2)).toEqual("2nd");
expect(getOrdinalNumber(22)).toEqual("22nd");
expect(getOrdinalNumber(52)).toEqual("52nd");
expect(getOrdinalNumber(72)).toEqual("72nd");
});

// Case 3: Identify the ordinal number for 3
// When the number is 3,
// Then the function should return "3rd"
test("works for any number ending in 3", () => {
expect(getOrdinalNumber(3)).toEqual("3rd");
expect(getOrdinalNumber(33)).toEqual("33rd");
expect(getOrdinalNumber(23)).toEqual("23rd");
expect(getOrdinalNumber(63)).toEqual("63rd");
});

// Case 4: Identify the ordinal number for 11, 12, 13
// When the number is num = 11, 12, 13
// Then the function should return "11st", "12nd", "13rd",
test("should return 'num th' for num", () => {
expect(getOrdinalNumber(11)).toEqual("11th");
expect(getOrdinalNumber(12)).toEqual("12th");
expect(getOrdinalNumber(13)).toEqual("13th");
});

// Case 5: Identify the ordinal number for any number not covered above, up to 100
// When the number is num = 4, 5,.... , 100
// Then the function should return "4th", "5th", "6th", "7th", "8th", "9th", "10th", "55th", ...
test("should return 'num th' for num", () => {
expect(getOrdinalNumber(4)).toEqual("4th");
expect(getOrdinalNumber(5)).toEqual("5th");
expect(getOrdinalNumber(6)).toEqual("6th");
expect(getOrdinalNumber(7)).toEqual("7th");
expect(getOrdinalNumber(8)).toEqual("8th");
expect(getOrdinalNumber(9)).toEqual("9th");
expect(getOrdinalNumber(10)).toEqual("10th");
expect(getOrdinalNumber(55)).toEqual("55th");
expect(getOrdinalNumber(46)).toEqual("46th");
expect(getOrdinalNumber(77)).toEqual("77th");
});
8 changes: 5 additions & 3 deletions Sprint-3/3-mandatory-practice/implement/repeat.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
function repeat() {
return "hellohellohello";
function repeat(str, count) {
if (count > 0) return `${str.repeat(count)}`;
else if (count == 0) return "";
else if (count < 0) return "negative counts are not valid";
}

module.exports = repeat;
module.exports = repeat;
Loading