Sheffield| May 2025| Mayowa Fadare| Structure testing sprint 3

[mayowa0-7]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

Made changes on the sprint 3 unit of the module structuring and testing, using the template provided

Questions

Ask any questions you have for your reviewer.

[cjyuan]

Does your function return the value you expected from each of the following function calls?

getCardValue("2A♠");
getCardValue("5.1♠");
getCardValue("0x02♠");

[cjyuan]

Have you checked if the above function calls can return the expected value?

[cjyuan]

Should also test if the function can return false when a password contains less than 5 characters.

[cjyuan]

The function can return false for multiple reasons.
To test a specific reason, choose an input that satisfies all other conditions except the one you're targeting. This way, if the function returns false, you can confidently attribute it to that specific condition.

For example, the function might return false for "strong1" because

1. it lacks an uppercase letter, OR
2. it lacks a non-alphanumeric character

As a result, when the function return false, we cannot be certain exactly why it returns false.

[cjyuan]

Changes look good.

Leaving responses directly in the comment threads makes tracking the discussion easier. You can try the approach in future PRs.

Here is a simplified version of best practices ChatGPT suggested for responding to inline comments in a pull request:

• ✅ Reply to every comment – Let the reviewer know you saw it.
• ✏️ Make the change if needed – Fix the code if the comment points out a real issue.
• 🤔 Explain if you don't agree – If you think the code is fine, politely explain why.
• ✅ Mark as resolved when done – Only mark comments resolved after you fix or respond.
• 💬 Keep replies short and polite – Be respectful and to the point.
• ⏱️ Respond soon – Don’t wait too long to reply.
• 🧪 Test your changes – Make sure your fixes actually work.
• 📍 Reply directly under the comment – This keeps the conversation easy to follow.