London 9 - Vitalina Kuzmenko - cyf-hotel-react #540
Conversation
…Buttons and Footer
…nside restaurant component
There was a problem hiding this comment.
This is crazy good Vitalina!! I'm so impressed 😮
I love how much care you have put into it all, from the way you've written functions, to commit messages and taking error handling into account 🥳
On thing I did notice, there are quite a few instances of using let over const, where it's not wrong, its a lot more common to use const for variables we are not reassigning, did you do this intentionally?
| @@ -14,6 +16,7 @@ | |||
| "eject": "react-scripts eject" | |||
| }, | |||
| "devDependencies": { | |||
| "eslint-plugin-react-hooks": "^4.6.0", | |||
| "husky": "^8.0.3", | |||
| "prettier": "^2.8.4", | |||
| "pretty-quick": "^3.1.3" | |||
There was a problem hiding this comment.
Do we we have our dependencies int he correct sections? 😃
There was a problem hiding this comment.
I don't know. I was installing dependencies using npm install. And it was installed automatically. Is something wrong with it?
There was a problem hiding this comment.
So there is just one issue, eslint should be included in the dev dependencies section.
There are two types of dependencies:
- "dependencies": Packages required by your application in production. (production is just the live website you deploy)
- "devDependencies": Packages that are only needed for local development and testing.
Eslint falls into the second one
There was a problem hiding this comment.
You can read more about this here: https://docs.npmjs.com/specifying-dependencies-and-devdependencies-in-a-package-json-file
There was a problem hiding this comment.
But I have it inside devDependencies, no?
"devDependencies": {
"eslint-plugin-react-hooks": "^4.6.0",
Maybe I will ask you personally about it :) Thank you!
deployment on Netlify: https://checkinn-hotel-react-website.netlify.app/