London-9-Turing-Farnoosh_Moayeri-React-WEEK1 #549
Conversation
|
@qingwei91 Hi, could you please review my code? |
src/App.js
Outdated
| return ( | ||
| <div className="App"> | ||
| <header className="App-header">CYF Hotel</header> | ||
| <Heading /> | ||
| <TouristInfoCards |
There was a problem hiding this comment.
small improvement: you can store these data in a data structure like a list of object, and then produce List of TouristInfoCards from that.
This approach will be more flexible, and less verbose
src/Bookings.js
Outdated
| console.info("TO DO!", searchVal); | ||
| const filteredBooking = bookings.filter((name) => | ||
| name.firstName.toLowerCase() === searchVal.toLowerCase() || | ||
| name.surname.toLowerCase() === searchVal.toLowerCase() || |
There was a problem hiding this comment.
I think the top 2 conidition might be redundant since you're performing includes search next?
There was a problem hiding this comment.
You are right, they can be deleted.
src/Bookings.js
Outdated
| name.surname.toLowerCase() === searchVal.toLowerCase() || | ||
| name.firstName.toLowerCase().includes(searchVal.toLowerCase()) || | ||
| name.surname.toLowerCase().includes(searchVal.toLowerCase()) | ||
| ? setBookings([name]) |
There was a problem hiding this comment.
If you're performing some state changes, it might be better to call setBookings outside of filter function.
Generally, filter function should be pure, pure in this context means it does not mutate any variables that is outside of the scope of the function.
Call setBookings outside of the filter function
|
@qingwei91 Thank you for the review; I fixed them, could you please review them? |
**CYF Hotel**