This repository was archived by the owner on Oct 26, 2020. It is now read-only.
Sulaiman week 8 #992
Open
Sulaiman week 8 #992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to follow previously sent common practice and instructions fixed some typos
Minor changes to make language consistent and simplify it where needed.
| .then(function(response) { | ||
| return response.text(); | ||
| }) | ||
| .then(function(greeting) { | ||
| // Write the code to display the greeting text here | ||
| let element = document.getElementById('greeting-text') | ||
| element.innerText = greeting | ||
| }); |
| .then(function(dogImage){ | ||
| imgTag.src = dogImage.message | ||
| }) | ||
| }); |
There was a problem hiding this comment.
Good work, you are missing the error handling after the fetched data and you could have separated your code and make it more understandable. clean Up you code only.
| }) | ||
| .then((data)=> | ||
| img.src = data.img | ||
| ) |
There was a problem hiding this comment.
Perfect, you are missing the error handling at the fetch data.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your Details
Your Name:
Your City:
Your Slack Name:
Homework Details
Module:
Week: