Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Term Entry] Python:SciPy scipy.optimize: minimize() #5908

Merged
merged 18 commits into from
Jan 15, 2025

Conversation

BoLiuV5
Copy link
Contributor

@BoLiuV5 BoLiuV5 commented Jan 2, 2025

Description

Added an entry on minimize() term under Python:SciPy by creating a minimize.md and refining its description, adding relevant subjects and tags, and providing an example usage.

Issue Solved

closes #5847

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented Jan 2, 2025

CLA assistant check
All committers have signed the CLA.

@mamtawardhani mamtawardhani self-assigned this Jan 2, 2025
@mamtawardhani mamtawardhani added new entry New entry or entries status: under review Issue or PR is currently being reviewed scipy Python scipy enteries labels Jan 2, 2025
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @BoLiu86 , thank you for contributing to Codecademy Docs, the entry is nicely written! 😄

I've suggested a few changes, could you please review and modify those at your earliest convenience? Thank you!

@BoLiuV5 BoLiuV5 changed the title Create minimize term for python scipy-optimize. Create minimize term for python scipy-optimize Jan 3, 2025
@BoLiuV5 BoLiuV5 changed the title Create minimize term for python scipy-optimize [Term Entry] Python:SciPy scipy.optimize: minimize() Jan 4, 2025
minor fixes
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to Codecademy Docs @BoLiuV5 😄

The entry looks good for a second round of review!🚀

Copy link
Collaborator

@dakshdeepHERE dakshdeepHERE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed formating issues and the indentation issues apart from that everything is fine.

@dakshdeepHERE dakshdeepHERE added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Jan 15, 2025
@dakshdeepHERE dakshdeepHERE merged commit ac2926b into Codecademy:main Jan 15, 2025
7 checks passed
Copy link

👋 @BoLiuV5
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/scipy/scipy-optimize/minimize

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, visit the linked accounts page and ensure that your GitHub account is linked.

@BoLiuV5
Copy link
Contributor Author

BoLiuV5 commented Jan 15, 2025

Hello, @dakshdeepHERE @mamtawardhani , I've linked my GitHub account. Can you please update the anonymous contributor to my name? Thank you!

@BoLiuV5 BoLiuV5 deleted the py-scipy-minimize branch January 15, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Term Entry] Python:SciPy scipy.optimize: minimize()
4 participants