Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Edit] Fix typo in CSS Overflow entry #5917

Merged
merged 7 commits into from
Jan 9, 2025

Conversation

joegorithm
Copy link
Contributor

Description

  • Edited the CSS Overflow concept file
  • Added a missing colon (:) on line 19 of /content/css/concepts/overflow/overflow.md

It was previously this:

- `hidden` When set to this value, any content that overflows will be hidden from view.

And I changed it to this to match other list items:

- `hidden`: When set to this value, any content that overflows will be hidden from view.

Type of Change

  • Editing an existing entry (fixing a typo, bug, issues, etc)

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented Jan 4, 2025

CLA assistant check
All committers have signed the CLA.

@mamtawardhani mamtawardhani self-assigned this Jan 6, 2025
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to Codecademy Docs @joegorithm 😄

The entry looks good for a second round of review! 🚀

Fixed the description. It was too long.
@Radhika-okhade Radhika-okhade added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Jan 8, 2025
@Radhika-okhade
Copy link
Collaborator

Thank you for contributing to Codecademy Docs @joegorithm 😄

The entry looks good to be merged. 🚀

@Radhika-okhade Radhika-okhade merged commit 28ca408 into Codecademy:main Jan 9, 2025
7 checks passed
Copy link

github-actions bot commented Jan 9, 2025

👋 @joegorithm
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/css/overflow

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, visit the linked accounts page and ensure that your GitHub account is linked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants