Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Illustration): added new stackedPagesIllustration #2939

Merged
merged 4 commits into from
Sep 23, 2024
Merged

feat(Illustration): added new stackedPagesIllustration #2939

merged 4 commits into from
Sep 23, 2024

Conversation

so-haa
Copy link
Contributor

@so-haa so-haa commented Sep 19, 2024 •
edited
Loading

Overview

Added a new illustration : StackedPages, that needs to be used in Teams Trial Modal

image (1)

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [IN-1167]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  1. Storybook Illustrations preview => path=/docs/atoms-illustrations--editable-illustration
  2. Search for StackedPages

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link Portal Env
Another Repo Another Link Another Env

@so-haa so-haa requested a review from a team as a code owner September 19, 2024 05:54
@CLAassistant
Copy link

CLAassistant commented Sep 19, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jakemhiller jakemhiller requested review from jakemhiller and removed request for LinKCoding September 19, 2024 18:39
jakemhiller
jakemhiller approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@jakemhiller jakemhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@so-haa so-haa added the Ship It :shipit: Automerge this PR when possible label Sep 23, 2024
@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev codecademydev merged commit 4173b45 into main Sep 23, 2024
16 of 18 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Sep 23, 2024
@codecademydev codecademydev deleted the stacked-pages-illustration branch September 23, 2024 15:20
@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://66f187a5a568a7318b024887--gamut-preview.netlify.app

Deploy Logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakemhiller jakemhiller jakemhiller approved these changes

@aresnik11 aresnik11 Awaiting requested review from aresnik11 aresnik11 is a code owner automatically assigned from Codecademy/gamut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@so-haa @CLAassistant @codecademydev @jakemhiller