feat(Video + Markdown): update react player + put videos in markdown #2941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamwasp
changed the title
dreamwasp
changed the title
aresnik11
reviewed
Oct 11, 2024
There was a problem hiding this comment.
2 things I noticed:
- On the Video story the props table isn't loading
Invalid name '', must include alphanumeric characters
[Read the docs](http://storybook.js.org/docs/)
- the video story with a placeholder image doesn't play the video when you click, you have to click twice
aresnik11
reviewed
Oct 11, 2024
| {(args) => { | ||
| return <Video {...args} />; | ||
| }} | ||
| </Story> | ||
| </Canvas> | ||
|
|
||
| ## Here is an example with a Viemo URL |
aresnik11
reviewed
Oct 11, 2024
| @@ -347,4 +347,18 @@ Use the `printf()` function. | |||
|
|
|||
| ### Iframes | |||
|
|
|||
| <iframe src="https://player.vimeo.com/video/145702525?byline=0&portrait=0&badge=0" width="640" height="360" frameborder="0" allow="autoplay; fullscreen" allowfullscreen></iframe> | |||
| Vimeo and Youtube video iframes will be rendered by our Video component, otherwise they'll render as stated. | |||
There was a problem hiding this comment.
nit: what does render as stated mean?
There was a problem hiding this comment.
i meant just renders the original code, i'll rephrase
📬Published Alpha Packages:@codecademy/[email protected] |
|
🚀 Styleguide deploy preview ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updates the react-player package to the newest version + makes the video component the default render component for iframed Vimeos + Youtubes
PR Checklist
Testing Instructions
PR Links and Envs