Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(InfoTip): background hover #2945

Merged
merged 5 commits into from
Oct 7, 2024
Merged

fix(InfoTip): background hover #2945

merged 5 commits into from
Oct 7, 2024

Conversation

dreamwasp
Copy link
Contributor

@dreamwasp dreamwasp commented Oct 4, 2024 •
edited
Loading

Overview

Realized while auditing the FloatingTip issue that InfoTip was missing its hover background

PR Checklist

  • Related to designs: Gamut Figma
  • Related to JIRA ticket: [tooltip-123]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  • Head to the InfoTip stories
  • InfoTip will now have a background color on hover

PR Links and Envs

tbd

@dreamwasp dreamwasp requested a review from aresnik11 October 4, 2024 20:09
@dreamwasp dreamwasp marked this pull request as ready for review October 4, 2024 20:09
@dreamwasp dreamwasp requested a review from a team as a code owner October 4, 2024 20:09
@dreamwasp dreamwasp requested a review from BandanaKM October 4, 2024 20:09
aresnik11
aresnik11 approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@aresnik11 aresnik11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@dreamwasp dreamwasp added the Ship It :shipit: Automerge this PR when possible label Oct 7, 2024
@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev codecademydev merged commit 21686f3 into main Oct 7, 2024
16 of 18 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Oct 7, 2024
@codecademydev codecademydev deleted the cass-infotip-hover branch October 7, 2024 14:25
@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://6703ef7d5a44d51b35abd534--gamut-preview.netlify.app

Deploy Logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aresnik11 aresnik11 aresnik11 approved these changes

@BandanaKM BandanaKM Awaiting requested review from BandanaKM BandanaKM is a code owner automatically assigned from Codecademy/gamut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dreamwasp @codecademydev @aresnik11