Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: disable nx cloud in CI #2969

Merged
merged 2 commits into from
Nov 6, 2024
Merged

chore: disable nx cloud in CI #2969

merged 2 commits into from
Nov 6, 2024

Conversation

jakemhiller
Copy link
Member

Overview

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [ABC-123]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link Portal Env
Another Repo Another Link Another Env

@jakemhiller jakemhiller changed the title dont make all tests depend on builds chore: don't make all tests depend on builds Nov 5, 2024
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Nov 5, 2024 •
edited
Loading

☁️ Nx Cloud Report

We didn't find any information for the current pull request with the commit 05bb18b.
Please verify you are running the latest version of the NxCloud runner.

Check the Nx Cloud Source Control Integration documentation for more information.

Alternatively, you can contact us at [email protected].

Sent with 💌 from NxCloud.

@jakemhiller jakemhiller changed the title chore: don't make all tests depend on builds chore: disable nx cloud in CI Nov 5, 2024
@jakemhiller jakemhiller marked this pull request as ready for review November 5, 2024 20:16
@jakemhiller jakemhiller requested a review from a team as a code owner November 5, 2024 20:16
@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://672a7e6cbeadb94132cad659--gamut-preview.netlify.app

Deploy Logs

@jakemhiller jakemhiller added the Ship It :shipit: Automerge this PR when possible label Nov 6, 2024
@codecademydev codecademydev merged commit c7e2495 into main Nov 6, 2024
20 of 21 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Nov 6, 2024
@codecademydev codecademydev deleted the jh-test-deps branch November 6, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aresnik11 aresnik11 aresnik11 approved these changes

@timjenkins timjenkins Awaiting requested review from timjenkins timjenkins is a code owner automatically assigned from Codecademy/gamut

@BandanaKM BandanaKM Awaiting requested review from BandanaKM BandanaKM is a code owner automatically assigned from Codecademy/gamut

@LinKCoding LinKCoding Awaiting requested review from LinKCoding

@dreamwasp dreamwasp Awaiting requested review from dreamwasp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakemhiller @codecademydev @aresnik11