Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Font): Load from same origin #2981

Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix(Font): Load from same origin #2981

merged 1 commit into from
Dec 3, 2024

Conversation

jrood
Copy link
Contributor

@jrood jrood commented Dec 2, 2024 •
edited
Loading

Overview

Request fonts on same origin so that font-face can use result from preload request.
See related RPW changes

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [ABC-123]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  • Open the Portal Preview Env
  • Open the network tab
  • Search for "apercu"
  • Note that fonts are loaded from www
Screenshot 2024-12-03 at 8 38 41 AM

PR Links and Envs

Portal PR
Portal Preview Env

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Dec 2, 2024 •
edited
Loading

☁️ Nx Cloud Report

We didn't find any information for the current pull request with the commit 4f7877f.
Please verify you are running the latest version of the NxCloud runner.

Check the Nx Cloud Source Control Integration documentation for more information.

Alternatively, you can contact us at [email protected].

Sent with 💌 from NxCloud.

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://674dfd4ab6333200b7844035--gamut-preview.netlify.app

Deploy Logs

@jrood jrood changed the title Load font from same origin Fix(Font) Load from same origin Dec 2, 2024
@jrood jrood changed the title Fix(Font) Load from same origin Fix(Font): Load from same origin Dec 2, 2024
@jrood jrood changed the title Fix(Font): Load from same origin fix(Font): Load from same origin Dec 2, 2024
@jrood jrood marked this pull request as ready for review December 3, 2024 14:40
@jrood jrood requested a review from a team as a code owner December 3, 2024 14:40
jakemhiller
jakemhiller approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@jakemhiller jakemhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jrood jrood added the Ship It :shipit: Automerge this PR when possible label Dec 3, 2024
@codecademydev codecademydev merged commit c3b616c into main Dec 3, 2024
38 of 43 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Dec 3, 2024
@codecademydev codecademydev deleted the jrood.same-origin-font branch December 3, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakemhiller jakemhiller jakemhiller approved these changes

@LinKCoding LinKCoding Awaiting requested review from LinKCoding LinKCoding is a code owner automatically assigned from Codecademy/gamut

@dreamwasp dreamwasp Awaiting requested review from dreamwasp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrood @codecademydev @jakemhiller