feat(fonts): Prioritize woff2 #3003
Open
+18
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 9d95ebc. ☁️ Nx Cloud last updated this comment at |
jrood
force-pushed
the
jrood.woff2-priority
branch
from
e89971f to
b161769
Compare
jrood
changed the title
jrood
force-pushed
the
jrood.woff2-priority
branch
from
b161769 to
cab68fb
Compare
jrood
force-pushed
the
jrood.woff2-priority
branch
from
cab68fb to
a72a8a9
Compare
jrood
force-pushed
the
jrood.woff2-priority
branch
from
a72a8a9 to
9d95ebc
Compare
|
🚀 Styleguide deploy preview ready! |
📬Published Alpha Packages:@codecademy/[email protected] |
jrood
requested review from
BandanaKM,
dreamwasp,
a team,
christian-dinh and
klcodecademy
and removed request for
a team
klcodecademy
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When we include a
@font-facedeclaration with multiple files (e.g. woff and woff2), the browser will try the first file given and only load subsequent files if the first fails. Since woff2 has better compression and is supported by all evergreen browsers (including Safari), we should list woff2 first. These files are rendered in@font-facedeclarations here.We also should only preload woff2 so that we don't waste critical early load-time network resources on woff1 files that likely won't be used.
PR Checklist
Related to designs:This PR includes unit tests for the code changeTesting Instructions
PR Links and Envs