Skip to content

Conversation

@SamMousa
Copy link

@SamMousa SamMousa commented Sep 4, 2025

No description provided.

@SamMousa SamMousa requested a review from TavoNiievez September 4, 2025 14:41
@SamMousa
Copy link
Author

SamMousa commented Sep 4, 2025

@TavoNiievez currently we have a weird dependency situation:

  1. module-asserts requires lib-asserts
  2. module-asserts requires codeception
  3. codeption requires lib-asserts
  4. codeception requires module-asserts

I've chosen to simplify it by importing lib-asserts into module-asserts (seems a bit overkill to have those 2 repos separated).
My proposal is to deprecate lib-asserts and have this package provide it.

What do you think?

Edit: actually this is wrong; codeception only has a dev-require for this repo...

@SamMousa SamMousa marked this pull request as draft September 4, 2025 14:49
@TavoNiievez
Copy link
Member

The real problem is modules depending on Codeception and vice versa.
Codeception/Codeception#6164 (comment)
In a perfect world, modules would be independent of Codeception, but in some cases this is difficult to achieve.

@SamMousa
Copy link
Author

SamMousa commented Sep 5, 2025

In a perfect world, modules would be independent of Codeception, but in some cases this is difficult to achieve.

Yeah, the whole module system is so complicated:

  • Dependencies
  • Conflicts
  • Partial modules
  • Dependent modules :-|

@W0rma
Copy link
Contributor

W0rma commented Oct 23, 2025

@SamMousa Do you still plan to integrate lib-asserts into this repo?

@SamMousa
Copy link
Author

Honestly, the mess of circular dependencies made it so that a simple upgrade already took me a day without much results and I'm not inclined to spend more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants