Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the add label API rather than patching the entire issue #89

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

manishprivet
Copy link

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

When adding a Label to the PR, we should use the Add Label API rather than the API to update the entire issue.

The current implementation can lead to unexpected behaviour if another labelling job is running in parallel, e.g., it can remove the label added by another job if timings match.

Notes to Reviewer

How to test

Link to issues addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants