Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(criteria-to-mongo): ✨ add criteria to mongo converter #14

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(criteria-to-mongo): ✨ add criteria to mongo converter #14

wants to merge 3 commits into from

Conversation

rfdez
Copy link

@rfdez rfdez commented Oct 11, 2024

Add criteria to MongoDB converter based on the MongoCriteriaConverter.ts of the typescript-ddd-example.

I would like to raise two questions regarding this criteria converter:

  • How should we refer to MongoDB: as "mongo" or "mongodb"? This distinction is important for naming the package and the types.
  • Should this package transform the id property to _id, or should it remain agnostic to identifier naming conventions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rfdez