Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inferencing unknown Type Improvement #11

Merged
merged 4 commits into from
Sep 4, 2024
Merged

Inferencing unknown Type Improvement #11

merged 4 commits into from
Sep 4, 2024

Conversation

johnnyhuirilef
Copy link
Contributor

Pull Request Checklist

Ensure your PR meets the following criteria before submission:

  • Code Quality
    • My code adheres to the project's coding and style guidelines.
    • I have performed a self-review of my own code.
    • I have commented my code, particularly in hard-to-understand areas.
  • Testing
    • Tests for the changes have been added (for bug fixes/features).
    • I have tested the changes and verified that existing functionalities are not broken.
    • I have added necessary unit tests.
  • Build & Lint
    • npm run build was executed locally, and any changes were pushed.
    • npm run lint has passed locally, and any fixes were made for failures.

Pull Request Type

Identify the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code Style Update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-Related Changes
  • Security Patch
  • UI/UX Improvement
  • Documentation Update
  • Other (please describe):

Description

The change made ensures that the system correctly infers data of type unknown. Previously, unknown was incorrectly inferred as never, which is not accurate and could cause issues when handling data in the project. This improvement ensures that unknown types are managed more precisely and appropriately.

Breaking Changes

  • Yes
  • No

Impact

This change improves the accuracy of inferring unknown types, which is crucial to avoid errors in data handling within the project. It is expected to have a positive impact on the stability and clarity of the code, as it prevents types from being incorrectly inferred as never. While no performance or dependency changes are anticipated, it is important to review areas of the code that rely on this inference to ensure they behave as expected.

Additional Information

This improvement is particularly relevant for developers working with uncertain data types and who need to ensure their code correctly handles unknown values. If there are any tests or functionalities that relied on the previous inference behavior, it is recommended to review them to ensure they still function as expected after this change.

Screenshots

Screenshot 2024-08-26 at 10 28 31
SCR-20240826-jpzf

Copy link
Member

@JavierCane JavierCane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution @johnnyhuirilef.

There is just a minor suggestion regarding the test case title to take a look and we will be good to go 🤟

tests/Primitives.test.ts Outdated Show resolved Hide resolved
@johnnyhuirilef
Copy link
Contributor Author

Hi @JavierCane

I’ve made the requested change to improve the test title as you suggested. I believe it now clearly reflects the test’s intent and will be easier for future maintainers to understand. Thank you so much for your valuable feedback!

Copy link
Member

@JavierCane JavierCane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Letsgooooo!

Merging & releasing a new version in 3…

@JavierCane JavierCane merged commit 617e4df into CodelyTV:main Sep 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants