Skip to content
This repository has been archived by the owner on Dec 14, 2023. It is now read-only.

Global error display query param #280

Merged
merged 1 commit into from
Jan 20, 2020
Merged

Global error display query param #280

merged 1 commit into from
Jan 20, 2020

Conversation

Jeddf
Copy link
Contributor

@Jeddf Jeddf commented Jan 20, 2020 •
edited
Loading

  • Toast style notification using vue-toasted package
  • Display error and strip query param out of URL
  • Temporarily allow any arbitrary error message while oauth is private

Screen Recording 2020-01-20 at 12 19 22

Relates to item in stage 2 of CoderDojo/community-platform#1290

@Jeddf
Global error display query param
f2e3c73 
- Toast style notification using vue-toasted package
- Displays error and strips query param out of URL
ArayB
ArayB approved these changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@ArayB ArayB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jeddf Jeddf merged commit 76b5229 into master Jan 20, 2020
@ArayB ArayB deleted the error-notify branch May 28, 2020 12:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ArayB ArayB ArayB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jeddf @ArayB