Skip to content
This repository has been archived by the owner on Dec 14, 2023. It is now read-only.

Oauth flow error handling #1386

Merged
merged 2 commits into from
Jan 20, 2020
Merged

Oauth flow error handling #1386

merged 2 commits into from
Jan 20, 2020

Conversation

Jeddf
Copy link
Contributor

@Jeddf Jeddf commented Jan 20, 2020

  • Oauth user error display - use new error display query param in zen frontend
  • Error logging on local dev (currently too noisy to turn on in prod)
  • Temporarily verbose client side messages while oauth flow is private

Relates to item in stage 2 of CoderDojo/community-platform#1290

Jeddf added 2 commits January 20, 2020 09:40
- Use new error display query param in zen frontend
- Temporarily verbose client side messages while oauth flow is private
Copy link
Contributor

@ArayB ArayB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

As these errors are user facing we will need to get the error messages into cp-translations at some point.

@Jeddf
Copy link
Contributor Author

Jeddf commented Jan 20, 2020

LGTM.

As these errors are user facing we will need to get the error messages into cp-translations at some point.

Agreed!

I had the thought that having someone be able to have our site show any error message to the user by redirecting them to our site with a query param is bad too so will restrict that ability before final release also.

@Jeddf Jeddf merged commit 77d783e into master Jan 20, 2020
@ArayB ArayB deleted the error-notify branch May 28, 2020 08:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants