This repository has been archived by the owner on Mar 20, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: create code snippets for api (#342) #396
base: main
Are you sure you want to change the base?
feat: create code snippets for api (#342) #396
Changes from 11 commits
9c5f372
bef7160
f4e09b5
4c68125
e23f446
bf7169a
a969d13
e1958ab
a8a2990
460e9d9
d8c2bf2
7d7e3ad
30017f5
79e016f
f55b5f1
b7acb8e
ff2fea9
dafd9a4
2fca352
e48ec16
9819224
c49f3b6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you change snippet like I suggested below, then you can change that snippet to this:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, we can go even further and change
applicationService.execute
interface to sth like this.Then inside
execute
we can map command to metadata and we don't need extra currying of domainFunction as proposed by @KrystianKjjk .What do you think @nowakprojects ?