Skip to content
This repository has been archived by the owner on Jun 24, 2019. It is now read-only.

Add Docker #51

Open
wants to merge 13 commits into
base: development
Choose a base branch
from
Open

Conversation

davisokoth
Copy link

This PR adds Docker for development purposes

Add Docker for development purposes
Add `eslint` for typescript
@crysfel
Copy link
Member

crysfel commented May 13, 2019

This is great! No need to install azure in our local anymore, I will try to run it on my local before approving.

Could you fix the conflicts? Thanks!

Copy link

@brentmclark brentmclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the settings.json conflict this LGTM. Does anything need to change in the README?

Dockerfile Outdated Show resolved Hide resolved
Resolve `.vscode/settings.json` conflict
@swissarmykirpan
Copy link
Collaborator

We should make sure it works with this: https://code.visualstudio.com/docs/remote/containers !

@davisokoth
Copy link
Author

We should make sure it works with this: https://code.visualstudio.com/docs/remote/containers !

Alright. Let me see to that!

@crysfel
Copy link
Member

crysfel commented May 20, 2019

@davisokoth Awesome! I tested in my local and I didn't have any issues when running docker-compose up, it seems like it works fine.

The only thing I'm seeing is when calling any of the endpoints, I'm getting this error:

Microsoft.Azure.WebJobs.Host.FunctionInvocationException: Exception while executing function: Functions.add-user ---> Microsoft.Azure.WebJobs.Script.Rpc.RpcException: Result: Failure
coding-coach-api_1  | Exception: Worker was unable to load function add-user: 'Error: Cannot find module '@repositories/user-repository''
coding-coach-api_1  | Stack: Error: Cannot find module '@repositories/user-repository'
coding-coach-api_1  |     at Function.Module._resolveFilename (module.js:548:15)
coding-coach-api_1  |     at Function.Module._load (module.js:475:25)
coding-coach-api_1  |     at Module.require (module.js:597:17)
coding-coach-api_1  |     at require (internal/module.js:11:18)
coding-coach-api_1  |     at Object.<anonymous> (/home/node/app/dist/handlers/add-user/add-user-handler.js:29:27)
coding-coach-api_1  |     at Module._compile (module.js:653:30)
coding-coach-api_1  |     at Object.Module._extensions..js (module.js:664:10)
coding-coach-api_1  |     at Module.load (module.js:566:32)
coding-coach-api_1  |     at tryModuleLoad (module.js:506:12)
coding-coach-api_1  |     at Function.Module._load (module.js:498:3)
coding-coach-api_1  |    at Microsoft.Azure.WebJobs.Script.Description.WorkerLanguageInvoker.InvokeCore(Object[] parameters, FunctionInvocationContext context) in C:\azure-webjobs-sdk-script\src\WebJobs.Script\Description\Rpc\WorkerLanguageInvoker.cs:line 74

It seems like is not loading this module @repositories/user-repository, which TS should resolve.

davisokoth and others added 6 commits June 18, 2019 17:24
Fixes error in seeing `@repositories`
Add `tslint` as a dev-dependency
Enforce `tslint` requirements in various files
Disable rule requiring ordering of imports to allow for `reflect-metadata` to be imported first
@davisokoth
Copy link
Author

@davisokoth Awesome! I tested in my local and I didn't have any issues when running docker-compose up, it seems like it works fine.

The only thing I'm seeing is when calling any of the endpoints, I'm getting this error:

Microsoft.Azure.WebJobs.Host.FunctionInvocationException: Exception while executing function: Functions.add-user ---> Microsoft.Azure.WebJobs.Script.Rpc.RpcException: Result: Failure
coding-coach-api_1  | Exception: Worker was unable to load function add-user: 'Error: Cannot find module '@repositories/user-repository''
coding-coach-api_1  | Stack: Error: Cannot find module '@repositories/user-repository'
coding-coach-api_1  |     at Function.Module._resolveFilename (module.js:548:15)
coding-coach-api_1  |     at Function.Module._load (module.js:475:25)
coding-coach-api_1  |     at Module.require (module.js:597:17)
coding-coach-api_1  |     at require (internal/module.js:11:18)
coding-coach-api_1  |     at Object.<anonymous> (/home/node/app/dist/handlers/add-user/add-user-handler.js:29:27)
coding-coach-api_1  |     at Module._compile (module.js:653:30)
coding-coach-api_1  |     at Object.Module._extensions..js (module.js:664:10)
coding-coach-api_1  |     at Module.load (module.js:566:32)
coding-coach-api_1  |     at tryModuleLoad (module.js:506:12)
coding-coach-api_1  |     at Function.Module._load (module.js:498:3)
coding-coach-api_1  |    at Microsoft.Azure.WebJobs.Script.Description.WorkerLanguageInvoker.InvokeCore(Object[] parameters, FunctionInvocationContext context) in C:\azure-webjobs-sdk-script\src\WebJobs.Script\Description\Rpc\WorkerLanguageInvoker.cs:line 74

It seems like is not loading this module @repositories/user-repository, which TS should resolve.

Am still not sure how to fix this. Any pointers?

Add a`Dockerfile` to set up ans spin an `azurite` instance
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants