Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export af forenings info indeholder nu også email for foreningerne #1162

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

mhewel
Copy link
Contributor

@mhewel mhewel commented Feb 9, 2025

Tilføjede flere felter til søgning på admin>Foreninger (svarende til søgning under Admin>afdelinger).
Test af admin siden, inklusiv test af CSV export. Kræver ny fælles folder i docker for selenium og web container.

Flere søgefelter (svarende til afdelinger).
Test af admin siden, inklusiv test af CSV export. Kræver ny fælles folder i docker for selenium og web container.
Copy link

what-the-diff bot commented Feb 9, 2025

PR Summary

  • Updated the ".gitignore" file
    Added test-files to the .gitignore file. The .gitignore file specifies intentionally untracked files that Git should ignore, and adding test-files means that changes in this directory will not be monitored by Git.

  • Modified Docker Compose configuration
    Updated docker-compose.yml file to bind the local ./test-files directory to the /app/test-files in two Docker services. This allows test-files to be available inside the Docker container during execution.

  • Enhanced Union Admin search functionality
    Improved the search capabilities in the UnionAdmin class. More fields were added to search_fields, making it possible to search using more criteria. Also, the text shown in the search help was updated to be more informative.

  • Enhanced Union Admin CSV export
    Updated the export_csv_union_info method in union_admin.py to include email in the CSV output. This means the generated CSV file will now contain an additional column for email data.

  • New Test file for Union Admin
    Added a new test file called test_admin_union.py. This file contains comprehensive functional tests, built with Selenium, to validate the Union admin functionalities including filtering, searching, and CSV exporting. This helps to ensure that the Union admin features work as expected.

Copy link
Contributor

@rasmusselsmark rasmusselsmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser fint ud. Har verificeret lokalt at e-mail adresse bliver eksporteret. Og gode tests, tak 👍

@rasmusselsmark rasmusselsmark self-requested a review February 9, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Inkluder foreningens mail i "Exporter Foreningsinformationer"
2 participants