Skip to content

Commit

Permalink
Fix behavior of the menu() function calls without user param (#6324)
Browse files Browse the repository at this point in the history
  • Loading branch information
Jackenmen authored Mar 23, 2024
1 parent 76c2c75 commit a26b9d6
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,12 @@ Changes
- **Core - Utils Package** - The `menu()` utility function received a new `provisional <developer-guarantees-exclusions>` ``user`` parameter for defining who can interact with the menu (instead of the default ``ctx.author``) (:issue:`4913`)

If no issues arise, we plan on including this parameter under developer guarantees
in the first release made after 2024-05-18.
in the first release made after 2024-05-24.

- **Core - Utils Package** - The `SimpleMenu.start()` method received a new `provisional <developer-guarantees-exclusions>` ``user`` parameter for defining who can interact with the menu (instead of the default ``ctx.author``) (:issue:`4913`)

If no issues arise, we plan on including this parameter under developer guarantees
in the first release made after 2024-05-18.
in the first release made after 2024-05-24.

Fixes
*****
Expand Down
6 changes: 3 additions & 3 deletions redbot/core/utils/menus.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ async def menu(
The ``user`` parameter is considered `provisional <developer-guarantees-exclusions>`.
If no issues arise, we plan on including it under developer guarantees
in the first release made after 2024-05-18.
in the first release made after 2024-05-24.
.. warning::
Expand Down Expand Up @@ -168,7 +168,7 @@ async def control_no(*args, **kwargs):
This parameter is `provisional <developer-guarantees-exclusions>`.
If no issues arise, we plan on including it under developer guarantees
in the first release made after 2024-05-18.
in the first release made after 2024-05-24.
Raises
------
Expand Down Expand Up @@ -287,7 +287,7 @@ async def control_no(*args, **kwargs):

if len(done) == 0:
raise asyncio.TimeoutError()
react, user = done.pop().result()
react, __ = done.pop().result()
except asyncio.TimeoutError:
if not ctx.me:
return
Expand Down
4 changes: 2 additions & 2 deletions redbot/core/utils/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ async def start(
The ``user`` parameter is considered `provisional <developer-guarantees-exclusions>`.
If no issues arise, we plan on including it under developer guarantees
in the first release made after 2024-05-18.
in the first release made after 2024-05-24.
Parameters
----------
Expand All @@ -263,7 +263,7 @@ async def start(
This parameter is `provisional <developer-guarantees-exclusions>`.
If no issues arise, we plan on including it under developer guarantees
in the first release made after 2024-05-18.
in the first release made after 2024-05-24.
ephemeral: `bool`
Send the message ephemerally. This only works
if the context is from a slash command interaction.
Expand Down

0 comments on commit a26b9d6

Please sign in to comment.