Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Audio] Update default forced application.yml #6414

Closed
aikaterna opened this issue Jul 31, 2024 · 0 comments · Fixed by #6415
Closed

[Audio] Update default forced application.yml #6414

aikaterna opened this issue Jul 31, 2024 · 0 comments · Fixed by #6415
Assignees
Labels
Category: Cogs - Audio This is related to the Audio cog. Status: In Progress There's a PR open to deal with this, or an org member is working on this internally Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.

Comments

@aikaterna
Copy link
Member

What Red version are you using?

3.5.10

What were you trying to do?

Play yt videos.

What did you expect to happen?

Effortless playback.

What actually happened?

A 403 error because we don't have the youtube-source plugin configured correctly.

How can we reproduce this error?

  1. Be on an affected machine/vps
  2. Play a yt video.
  3. Experience a 403 error because we should be trying other sources on the plugin first, before the ones defined in the base default configuration.
    ...

Anything else?

We should be using an application.yml that's structured in this manner instead of what we are currently distributing: Cog-Creators/Lavalink-Jars#15 (comment)
We need to consider the changes made in #6373 - we need to test whether the plugin fails when not configured properly: "As for the configuration, it depends on what happens when the plugin isn't on the list of plugins (as is the case when you disable yt source in settings). If it means that LL won't start then that place will not be suitable. This is how we do things for the plugin now, it's not always present" (referring to #6373)
The changes should be made in the area starting at this line:

DEFAULT_LAVALINK_YAML = {

@aikaterna aikaterna added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Jul 31, 2024
@github-actions github-actions bot added the Status: Needs Triage This has not been labeled or discussed for handling yet. label Jul 31, 2024
@aikaterna aikaterna added this to the 3.5.11 milestone Jul 31, 2024
@aikaterna aikaterna added the Release Blocker This needs handling prior to the next non-hotfix release. label Jul 31, 2024
@Jackenmen Jackenmen self-assigned this Jul 31, 2024
@Jackenmen Jackenmen added Status: In Progress There's a PR open to deal with this, or an org member is working on this internally Category: Cogs - Audio This is related to the Audio cog. and removed Status: Needs Triage This has not been labeled or discussed for handling yet. labels Jul 31, 2024
@Jackenmen Jackenmen removed the Release Blocker This needs handling prior to the next non-hotfix release. label Aug 4, 2024
@Jackenmen Jackenmen removed this from the 3.5.12 milestone Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Cogs - Audio This is related to the Audio cog. Status: In Progress There's a PR open to deal with this, or an org member is working on this internally Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants