Bump YT source plugin version to 1.5.1 and add custom plugin config #6415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackenmen
added
Type: Bug
aikaterna
approved these changes
Aug 4, 2024
red-githubbot
bot
added
the
Changelog Entry: Pending
BenCos17
added a commit
to JARVIS-discordbot/Red-DiscordBot-jarvis
that referenced
this pull request
Aug 4, 2024
* Set ProcessType in macOS auto-restart service to 'interactive' (Cog-Creators#6416) * Forcefully shutdown RPC to prevent hangs (Cog-Creators#6412) * Bump YT source plugin version to 1.5.1 and add custom plugin config (Cog-Creators#6415) --------- Co-authored-by: Jakub Kuczys <[email protected]> Co-authored-by: Kowlin <[email protected]>
Jackenmen
added
Changelog Entry: Added
BenCos17
added a commit
to JARVIS-discordbot/Red-DiscordBot-jarvis
that referenced
this pull request
Aug 4, 2024
* Set ProcessType in macOS auto-restart service to 'interactive' (Cog-Creators#6416) * Forcefully shutdown RPC to prevent hangs (Cog-Creators#6412) * Bump YT source plugin version to 1.5.1 and add custom plugin config (Cog-Creators#6415) * Fix unmuting when a mod isn't a mod anymore. (Cog-Creators#6411) Co-authored-by: TrustyJAID <[email protected]> * Bump dependencies (Cog-Creators#6417) * Red 3.5.11 - Changelog (Cog-Creators#6418) * Automated Crowdin downstream (Cog-Creators#6420) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Version bump to 3.5.11 (Cog-Creators#6419) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jakub Kuczys <[email protected]> * Version bump to 3.5.12.dev1 (Cog-Creators#6421) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: Jakub Kuczys <[email protected]> Co-authored-by: Kowlin <[email protected]> Co-authored-by: TrustyJAID <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Dav-Git
pushed a commit
to Dav-Git/Red-DiscordBot
that referenced
this pull request
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Fixes #6414 and bumps YT source plugin version.
I tested that this works properly both with the YT source disabled (i.e. when the manager doesn't add the YT plugin section) and enabled. It works in both cases and generates the following application.yml files:
The
change_dict_naming_convention()function had to be updated since it apparently assumed that when it encounters a list, that list is going to consist of dicts. This is not the case for the newplugins.youtube.clientskey - it consists of strings.Have the changes in this PR been tested?
Yes