Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Help] Allow prefix formatting in taglines #4972

Merged
merged 11 commits into from
Jan 2, 2024

Conversation

Kreusada
Copy link
Member

@Kreusada Kreusada commented Apr 8, 2021

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Allow the use of [p] to be replaced with the invoked prefix inside taglines. Fixes #4669.

@github-actions github-actions bot added the Category: Core - Help This is related to our help command and/or HelpFormatter API. label Apr 8, 2021
@Drapersniper Drapersniper added this to the 3.5.0 milestone May 31, 2021
@Jackenmen Jackenmen added the Type: Enhancement Something meant to enhance existing Red features. label Jun 27, 2021
@Jackenmen
Copy link
Member

Contributes towards #4669.

Any reason why it only contributes towards that issue but doesn't fix it? I'm not sure what I am missing here that this PR doesn't fix.

@Kreusada
Copy link
Member Author

Contributes towards #4669.

Any reason why it only contributes towards that issue but doesn't fix it? I'm not sure what I am missing here that this PR doesn't fix.

Reason why I said "contributes" is because the idea of referencing the command object was also mentioned in the issue, of which I did not include in this PR. But I guess that was just a side-note, so yes this PR will fix the main outline of the issue.

@Jackenmen
Copy link
Member

Thanks for clarifying, that does make sense indeed. I'll update this PR's description to say it fixes #4669 then and comment on the issue with more information.

@github-actions github-actions bot added the Category: Docs - Other This is related to documentation that doesn't have its dedicated label. label Aug 8, 2021
@github-actions github-actions bot added Category: Core - Bot Commands This is related to core commands (Core and CogManagerUI cog classes). and removed Category: Docs - Other This is related to documentation that doesn't have its dedicated label. labels Jan 2, 2024
@Flame442 Flame442 self-assigned this Jan 2, 2024
@Flame442 Flame442 merged commit 47a267b into Cog-Creators:V3/develop Jan 2, 2024
17 checks passed
@red-githubbot red-githubbot bot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Jan 2, 2024
@Jackenmen Jackenmen added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Mar 22, 2024
Dav-Git pushed a commit to Dav-Git/Red-DiscordBot that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Core - Bot Commands This is related to core commands (Core and CogManagerUI cog classes). Category: Core - Help This is related to our help command and/or HelpFormatter API. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Help] Tagline formatting
4 participants