[Mutes/Core] RelativeDeltaWithReason #5402
Open
+324
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flame442
added
Type: Feature
|
Can you solve the 2 conflicts when you get a chance? |
|
Conflicts have been resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the converter from the mutes cog which converts a string into a timedelta and a string reason and adds it to
redbot.core.commands.converter. Also implements a version of this converter which produces a relativedelta and a string reason, as well as functions which can be used to just do the conversion process on an arbitrary string. Swapsmutesto useredbot.core.commands.converterconverters, including these.Specific implementation details are subject to change, including typehints and method names. Some things I really just did not understand are omitted. This PR is untested beyond ensuring it works under the most expected of situations.
This PR serves to satisfy the
mutespart of #5244. This PR implements the changes to the regex present in #5393 in new regex strings, however does not modify the existing strings in an attempt to not conflict with that PR.