Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move private things in modlog and redbot.core.errors #6020

Merged
merged 4 commits into from
Jan 26, 2025
Merged

Move private things in modlog and redbot.core.errors #6020

merged 4 commits into from
Jan 26, 2025

Conversation

Jackenmen
Copy link
Member

@Jackenmen Jackenmen commented Apr 15, 2023 •
edited
Loading

Description of the changes

Part of the remainder from #6021 - moving things around in redbot.core.modlog and redbot.core.errors.

Changes are described in the commit titles.

Have the changes in this PR been tested?

Yes

@Jackenmen Jackenmen added Type: Enhancement Something meant to enhance existing Red features. Breaking Change Will potentially break some cogs. labels Apr 15, 2023
@github-actions github-actions bot added Category: Core - API - Config This is related to the `redbot.core.config` module and `redbot.core.drivers` package. Category: Core - Modlog This is related to the core Modlog API. Category: Core - RPC/ZMQ Related to provided (provisional) API for implementing RPC in cogs Category: Core - API - Other This is related to core APIs that don't have a dedicated label. Category: Core - Bot Class This is related to the `redbot.core.bot.Red` class. Category: Core - Bot Commands This is related to core commands (Core and CogManagerUI cog classes). Category: Core - Command-line Interfaces This is related to Red's CLIs (redbot, redbot-launcher, redbot-setup). Category: Core - Other Internals This is related to core internals that don't have a dedicated label. Category: Docs - Other This is related to documentation that doesn't have its dedicated label. Category: Meta This is related to the repository maintenance. labels Apr 15, 2023
@Jackenmen Jackenmen force-pushed the privatize_easy_things branch 2 times, most recently from 8ad7a1e to f010ffb Compare April 15, 2023 21:09
@Jackenmen Jackenmen added this to the 3.5.1 milestone Apr 15, 2023
@Jackenmen Jackenmen mentioned this pull request May 3, 2023
Merged
@Jackenmen Jackenmen removed the Breaking Change Will potentially break some cogs. label May 8, 2023
@Jackenmen Jackenmen force-pushed the privatize_easy_things branch from f010ffb to 62b3e0b Compare May 8, 2023 09:28
@github-actions github-actions bot removed Category: Core - Bot Class This is related to the `redbot.core.bot.Red` class. Category: Core - RPC/ZMQ Related to provided (provisional) API for implementing RPC in cogs Category: Docs - Other This is related to documentation that doesn't have its dedicated label. Category: Core - Other Internals This is related to core internals that don't have a dedicated label. Category: Core - Command-line Interfaces This is related to Red's CLIs (redbot, redbot-launcher, redbot-setup). Category: Meta This is related to the repository maintenance. labels May 8, 2023
@Jackenmen Jackenmen changed the title Privatize things that shouldn't **and aren't** be used outside Red Prefix modlog.handle_auditype_key with _ and move MissingExtraRequirements out of public namespace May 8, 2023
@Jackenmen Jackenmen changed the title Prefix modlog.handle_auditype_key with _ and move MissingExtraRequirements out of public namespace Move private things in modlog and redbot.core.errors May 8, 2023
@Jackenmen Jackenmen modified the milestones: 3.5.3, 3.5.2 May 11, 2023
@Jackenmen Jackenmen modified the milestones: 3.5.2, 3.6.0, 3.5.3 May 12, 2023
@Jackenmen Jackenmen modified the milestones: 3.5.6, 3.5.7 Mar 18, 2024
@Jackenmen Jackenmen modified the milestones: 3.5.9, 3.5.10 Apr 20, 2024
@Jackenmen Jackenmen modified the milestones: 3.5.14, 3.5.x Dec 24, 2024
@Flame442 Flame442 self-assigned this Jan 26, 2025
@Flame442 Flame442 modified the milestones: 3.5.x, 3.5.15 Jan 26, 2025
Flame442
Flame442 approved these changes Jan 26, 2025
View reviewed changes
Copy link
Member

@Flame442 Flame442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cat-slide

@Flame442 Flame442 merged commit 8b1daf1 into Cog-Creators:V3/develop Jan 26, 2025
17 checks passed
@red-githubbot red-githubbot bot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Jan 26, 2025
@Jackenmen Jackenmen deleted the privatize_easy_things branch January 26, 2025 23:50
@Jackenmen Jackenmen modified the milestones: 3.5.16, 3.5.15 Feb 3, 2025
@Jackenmen Jackenmen added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flame442 Flame442 Flame442 approved these changes

Assignees

@Flame442 Flame442

Labels
Category: Core - API - Config This is related to the `redbot.core.config` module and `redbot.core.drivers` package. Category: Core - API - Other This is related to core APIs that don't have a dedicated label. Category: Core - Bot Commands This is related to core commands (Core and CogManagerUI cog classes). Category: Core - Modlog This is related to the core Modlog API. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Milestone
3.5.15
Development

Successfully merging this pull request may close these issues.
2 participants
@Jackenmen @Flame442