Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release helper not considering workflow status #6320

Conversation

Jackenmen
Copy link
Member

Description of the changes

Apparently gh run watch will only consider the workflow status if the --exit-status flag is passed. This does that + some additional handling to revert to a usable state without the need for manual alteration of the repository's Git configuration.

Have the changes in this PR been tested?

No

@Jackenmen Jackenmen added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Mar 22, 2024
@github-actions github-actions bot added the Category: Meta This is related to the repository maintenance. label Mar 22, 2024
@Jackenmen Jackenmen merged commit 76c2c75 into Cog-Creators:V3/develop Mar 23, 2024
18 checks passed
@red-githubbot red-githubbot bot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Mar 23, 2024
@Jackenmen Jackenmen deleted the fix_release_helper_not_considering_exit_status branch March 23, 2024 23:15
Dav-Git pushed a commit to Dav-Git/Red-DiscordBot that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Meta This is related to the repository maintenance. Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant