Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Downloader] Support [botname] substitutions in cog install messages #6443

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

Kreusada
Copy link
Member

@Kreusada Kreusada commented Sep 1, 2024

Description of the changes

Support [botname] substitutions in downloader install messages. [p] is already supported, it would make sense to support [botname] too and to prevent confusion.

Have the changes in this PR been tested?

Yes

@Kreusada Kreusada requested a review from Jackenmen as a code owner September 1, 2024 13:38
@github-actions github-actions bot added the Category: Cogs - Downloader This is related to the Downloader cog. label Sep 1, 2024
@Kreusada Kreusada added the Type: Enhancement Something meant to enhance existing Red features. label Sep 1, 2024
Copy link
Member

@Kowlin Kowlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but once we're starting to add more then 2 arguments to replace we really gotta consider a helper function to handle that sort of stuff for us.

@Kowlin Kowlin merged commit d304da7 into Cog-Creators:V3/develop Sep 11, 2024
17 checks passed
@red-githubbot red-githubbot bot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Sep 11, 2024
@Jackenmen Jackenmen added this to the 3.5.14 milestone Dec 22, 2024
@Jackenmen Jackenmen added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Cogs - Downloader This is related to the Downloader cog. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants