Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert python 2 scripts to python 3 scripts #40

Closed
wants to merge 3 commits into from

Conversation

zxdawn
Copy link

@zxdawn zxdawn commented Jun 1, 2018

This commit resolves #39.

@behr-github
Copy link
Contributor

I appreciate the contribution, but I need to be able to verify that it does not break existing functionality and remains compatible with Python 2 and 3 so as to not break existing users' workflows. I will leave this open until I have time to write a test suite.

@zxdawn
Copy link
Author

zxdawn commented Jun 3, 2018

@behr-github Thank you. I suggest that you can use sys.version_info.major == 3 to check the version. If that's true, just run 2to3 -w . in the rep directory. Maybe, you need time to test whether all of these functions work fine in py3.

@zxdawn zxdawn closed this Jun 5, 2018
@zxdawn zxdawn deleted the xin_dev branch June 5, 2018 00:52
@zxdawn zxdawn mentioned this pull request Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert py2 to py3
2 participants