-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix jitpack #765
Fix jitpack #765
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev4 #765 +/- ##
============================================
- Coverage 66.70% 66.70% -0.01%
+ Complexity 2407 2406 -1
============================================
Files 322 322
Lines 13946 13946
Branches 1586 1586
============================================
- Hits 9303 9302 -1
Misses 3922 3922
- Partials 721 722 +1 ☔ View full report in Codecov by Sentry. |
sdkman init and update can be skipped, jitpack does those two steps automatically. Take a look at the renderer jitpack.yml |
I've removed these 2 steps |
@0x3C50 It looks this is incorrect, as removing this results in a failed build on JitPack. https://jitpack.io/com/github/Col-E/Recaf/dev4-45a626cce9-1/build.log I've added https://jitpack.io/com/github/Col-E/Recaf/02da7a89cc/build.log |
the build works on renderer. try openjdk? |
Ah I see the discrepancy, in renderer the The update made to this PR didn't include it. Looks like both |
What's new
Nothing
What's fixed
Jitpack
By default, jitpack uses java 8, this PR adds a
jitpack.yml
that tells it to use java 17