Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enigma mappings improve 2 #905

Merged
merged 3 commits into from
Jan 11, 2025
Merged

Conversation

Janmm14
Copy link
Contributor

@Janmm14 Janmm14 commented Jan 9, 2025

Rewrote the parser.

  • Still using indices for fast string parsing
  • Fixed inner classes again
  • Should be able to create better error messages
  • Improved tolerance for bogus spaces
  • Basic indent validation
  • No state machine, state is handled by code flow

Please give feedback on complexity and maintainability.

It seems to a little faster than the previous one. Speed about the same as the previous new impl.
Due to lambda usage MemberMappingsConsumer for code clarity, first shot speed is a little slower.

@Col-E Col-E merged commit af7d9da into Col-E:master Jan 11, 2025
1 check passed
@Col-E
Copy link
Owner

Col-E commented Jan 11, 2025

Please give feedback on complexity and maintainability.

Compared to the prior state-machine based system, this is much easier. I was able to read through the utility methods and easily fill in doc comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants